Skip to content

chore(playground): add "type": "module" to package.json#3566

Merged
pi0 merged 1 commit into
nitrojs:v3from
iiio2:chore/provide-type-module-to-playground
Sep 11, 2025
Merged

chore(playground): add "type": "module" to package.json#3566
pi0 merged 1 commit into
nitrojs:v3from
iiio2:chore/provide-type-module-to-playground

Conversation

@iiio2

@iiio2 iiio2 commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

though it is in playground, i had read "type": "module" has some performance related issue if we do not explicitly mention it. that is why I've thought we can add it here. (https://nodejs.org/en/blog/release/v20.19.0#module-syntax-detection-is-now-enabled-by-default)

@iiio2 iiio2 requested a review from pi0 as a code owner September 9, 2025 16:44
@vercel

vercel Bot commented Sep 9, 2025

Copy link
Copy Markdown

@iiio2 is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@pi0 pi0 changed the title build: provide "type": "module" to playground chore(playground): add "type": "module" to package.json Sep 11, 2025
@pi0 pi0 merged commit b6dbc0f into nitrojs:v3 Sep 11, 2025
4 of 5 checks passed
@iiio2

iiio2 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @pi0 .

@iiio2 iiio2 deleted the chore/provide-type-module-to-playground branch September 12, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants